Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce [ltr, rtl] layout direction service #1719

Closed
kara opened this issue Nov 3, 2016 · 4 comments
Closed

Introduce [ltr, rtl] layout direction service #1719

kara opened this issue Nov 3, 2016 · 4 comments
Assignees
@EladBezalel
Labels
needs: discussion Further discussion with the team is needed before proceeding

Comments

@kara
Copy link
Contributor

kara commented Nov 3, 2016

Similar to what the Dir directive does, but will also capture "dir" attributes outside the Angular app.

cc: @jelbourn
@kara kara added the discussion label Nov 3, 2016
@kara kara mentioned this issue Nov 3, 2016
Closed
@jelbourn jelbourn changed the title Introduce layout direction service Introduce [ltr, rtl] layout direction service Nov 9, 2016
@jelbourn
Copy link
Member

jelbourn commented Dec 9, 2016

@EladBezalel would you be interested in working on this? I have some thoughts in mind for it

@jelbourn jelbourn mentioned this issue Dec 9, 2016
Closed
@EladBezalel
Copy link
Member

@jelbourn sure! i'm always up to RTL stuff :D

@EladBezalel EladBezalel self-assigned this Dec 12, 2016
@jelbourn jelbourn mentioned this issue Dec 14, 2016
Closed
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Dec 19, 2016
@EladBezalel
feat(layout-direction): a service to accompany the Dir directive
fd9b073 
- Finds the application root element and traverses upwards and looking for dir attribute
- If Dir directive is available throughout the application it will be injected instead the activeLayoutDirection service

fixes angular#1719
@EladBezalel EladBezalel mentioned this issue Dec 19, 2016
Closed
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Dec 26, 2016
@EladBezalel
feat(layout-direction): a service to accompany the Dir directive
0e77ce7 
- Finds the application root element and traverses upwards and looking for dir attribute
- If Dir directive is available throughout the application it will be injected instead the activeLayoutDirection service

fixes angular#1719
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jan 12, 2017
@EladBezalel
feat(layout-direction): a service to accompany the Dir directive
33decab 
- Finds the application root element and traverses upwards and looking for dir attribute
- If Dir directive is available throughout the application it will be injected instead the activeLayoutDirection service

fixes angular#1719
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jan 12, 2017
@EladBezalel
feat(layout-direction): a service to accompany the Dir directive
d2e7d3e 
- Finds the application root element and traverses upwards and looking for dir attribute
- If Dir directive is available throughout the application it will be injected instead the activeLayoutDirection service

fixes angular#1719
amitport added a commit to amitport/flex-layout that referenced this issue Mar 9, 2017
@amitport
removed unused Dir directive
164e241 
it is a very confusing mention of a directive that is not actually used in this demo.
Additionally, looks setting this on router root is likely to change (see angular/components#1719)
@amitport amitport mentioned this issue Mar 9, 2017
Merged
amitport added a commit to amitport/flex-layout that referenced this issue Mar 10, 2017
@amitport
chore(demo): remove unnecessary attributes
179f688 
it is a very confusing mention of a directive that is not actually used in this demo.
Additionally, looks setting this on router root is likely to change (see angular/components#1719)
tinayuangao pushed a commit to angular/flex-layout that referenced this issue Mar 10, 2017
@amitport @tinayuangao
chore(demo): remove unnecessary attributes (#209)
044632e 
it is a very confusing mention of a directive that is not actually used in this demo.
Additionally, looks setting this on router root is likely to change (see angular/components#1719)
@EladBezalel EladBezalel mentioned this issue Mar 14, 2017
Closed
@EladBezalel
Copy link
Member

Simpler solution on #3600

karlhaas pushed a commit to karlhaas/flex-layout that referenced this issue May 3, 2017
@amitport @karlhaas
chore(demo): remove unnecessary attributes (angular#209)
db4d65a 
it is a very confusing mention of a directive that is not actually used in this demo.
Additionally, looks setting this on router root is likely to change (see angular/components#1719)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
@mmalerba mmalerba added the needs: discussion Further discussion with the team is needed before proceeding label Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EladBezalel EladBezalel

Labels
needs: discussion Further discussion with the team is needed before proceeding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(layout-direction): a service to accompany the Dir directive EladBezalel/material2
4 participants
@jelbourn @kara @EladBezalel @mmalerba