Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap test is failing after 4.0.0 went beta #7358

Closed
Brocco opened this issue Aug 11, 2017 · 6 comments · Fixed by #7360
Closed

Bootstrap test is failing after 4.0.0 went beta #7358

Brocco opened this issue Aug 11, 2017 · 6 comments · Fixed by #7360

Comments

@Brocco
Copy link
Contributor

Brocco commented Aug 11, 2017

This test is failing because there is no longer a dependency on jQuery.

The test linked to above needs updated accordingly.

Note: as it currently stands, CI will not pass until this is resolved.

Brocco added a commit to Brocco/angular-cli that referenced this issue Aug 11, 2017
The upgrade from alpha to beta of bootstrap 4 dropped the dependency on jQuery

Fixes angular#7358
@JSMike
Copy link
Contributor

JSMike commented Aug 11, 2017

there is no longer a dependency on jQuery.

and there was much rejoicing!

@JSMike
Copy link
Contributor

JSMike commented Aug 11, 2017

@Brocco bootstrap.js for boostrap beta still requires jQuery :(

if (typeof jQuery === 'undefined') {
  throw new Error('Bootstrap\'s JavaScript requires jQuery. jQuery must be included before Bootstrap\'s JavaScript.')
}

@brunobaiano
Copy link

and popper.js

Brocco added a commit that referenced this issue Aug 11, 2017
The upgrade from alpha to beta of bootstrap 4 dropped the dependency on jQuery

Fixes #7358
@pkozlowski-opensource
Copy link
Member

For anyone who is using Bootstrap 4 with Angular and doesn't want to jump through all the jQuery / popper.js hops, we've just release beta version of native Angular directives (no need for jQuery, no need for popper.js: https://ng-bootstrap.github.io. It is fully compatible with Bootstrap 4 beta released today.

@ghost
Copy link

ghost commented Sep 1, 2017

Is there documentation on how to go from the Bootstrap Sass package that is generated/used by this CLI to BS 4?

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
The upgrade from alpha to beta of bootstrap 4 dropped the dependency on jQuery

Fixes angular#7358
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants