Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy loaded modules do not contain crossorigin attribute #16801

Closed
rupebac opened this issue Jan 30, 2020 · 2 comments · Fixed by #16810
Closed

Lazy loaded modules do not contain crossorigin attribute #16801

rupebac opened this issue Jan 30, 2020 · 2 comments · Fixed by #16810
Assignees
@alan-agius4
Labels
area: devkit/build-angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone
Backlog

Comments

@rupebac
Copy link

rupebac commented Jan 30, 2020

🐞 bug report

Affected Package

@angular-devkit/build-angular

Is this a regression?

No

Description

Specifying 'crossOrigin: "anonymous"' in angular.json makes angular cli to add the corresponding attribute in the <script> elements of the <body>, but angular is still not appending it in the lazy loaded modules in the <head> during runtime.

Lazy loaded modules will only contain the crossorigin attribute hardcoded to 'anonymous', only if "subresourceIntegrity" is true. In this case, also the integrity attribute is added, and in our case this is not desired.

Expected is, that <script> from lazy loaded modules behave in the same way as <script> from angular.

🌍 Your Environment

"@angular/cli": "8.3.18",
"@angular/compiler-cli": "8.2.13",
"@angular/language-service": "8.2.13",
@AndrewKushnir
Copy link

Hi @rupebac, this looks like Angular CLI question, so I'm moving this ticket to Angular CLI repo for further investigation. Thank you.

@AndrewKushnir AndrewKushnir transferred this issue from angular/angular Jan 30, 2020
@alan-agius4 alan-agius4 added area: devkit/build-angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix labels Jan 30, 2020
@ngbot ngbot bot modified the milestone: Backlog Jan 30, 2020
@alan-agius4 alan-agius4 modified the milestones: Backlog, v9-candidates Jan 30, 2020
@ngbot ngbot bot added this to the Backlog milestone Jan 30, 2020
@alan-agius4 alan-agius4 self-assigned this Jan 31, 2020
@alan-agius4 alan-agius4 mentioned this issue Jan 31, 2020
Merged
mgechev pushed a commit that referenced this issue Feb 4, 2020
@alan-agius4 @mgechev
fix(@angular-devkit/build-angular): add crossorigin attribute to lazy…
c3aa081 
… chunks

Fixes #16801
mgechev pushed a commit that referenced this issue Feb 4, 2020
@alan-agius4 @mgechev
fix(@angular-devkit/build-angular): add crossorigin attribute to lazy…
085e011 
… chunks

Fixes #16801
mgechev pushed a commit that referenced this issue Feb 4, 2020
@alan-agius4 @mgechev
fix(@angular-devkit/build-angular): add crossorigin attribute to lazy…
b609d10 
… chunks

Fixes #16801
@snyk-bot snyk-bot mentioned this issue Feb 28, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alan-agius4 alan-agius4

Labels
area: devkit/build-angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(@angular-devkit/build-angular): add crossorigin attribute to lazy…
3 participants
@rupebac @alan-agius4 @AndrewKushnir