Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Puppeteer to 1.18 #355

Closed
angrykoala opened this issue May 8, 2019 · 5 comments
Closed

Update Puppeteer to 1.18 #355

angrykoala opened this issue May 8, 2019 · 5 comments
Labels
blocked Block by external issue or cause, defined in the description
Milestone
2.2

Comments

@angrykoala
Copy link
Owner

Blocked by #354

Puppeteer 1.15.0 does not properly respond to 422 errors
@angrykoala angrykoala added the blocked Block by external issue or cause, defined in the description label May 8, 2019
@angrykoala angrykoala added this to the 2.1 milestone May 8, 2019
@angrykoala angrykoala mentioned this issue May 20, 2019
Closed
@angrykoala
Copy link
Owner Author

Some examples with raw Puppeteer reproducing the 422 status code problem reported at:
puppeteer/puppeteer#4454

@angrykoala
Copy link
Owner Author

Incognito appears to not be working properly on 1.16.0

@angrykoala angrykoala changed the title Update Puppeteer to 1.15.0 or higher Update Puppeteer to 1.16.0 or higher May 20, 2019
@angrykoala
Copy link
Owner Author

Incognito is working as expected, recent changes in chromium make the test unreliable. Failing tests will be removed

@angrykoala angrykoala removed this from the 2.1 milestone May 22, 2019
@angrykoala
Copy link
Owner Author

Issue still happening on Puppeteer@1.17.0

@angrykoala
Copy link
Owner Author

angrykoala commented Jun 10, 2019 •
edited

Release of puppeteer@1.18 (est. June, 21st) should fix the regression problem

@angrykoala angrykoala changed the title Update Puppeteer to 1.16.0 or higher Update Puppeteer to 1.18 Jun 10, 2019
@angrykoala angrykoala added this to the 2.2 milestone Jun 13, 2019
angrykoala pushed a commit that referenced this issue Jun 21, 2019
puppeteer updated to 1.18.0, close #355
9246bce
angrykoala added a commit that referenced this issue Jul 8, 2019
@angrykoala
puppeteer updated to 1.18.0, close #355
79d60e6
angrykoala added a commit that referenced this issue Jul 8, 2019
@angrykoala
puppeteer updated to 1.18.0, close #355
2866a52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Block by external issue or cause, defined in the description
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
1 participant
@angrykoala