Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the plugin build system and toolings cross-platform compatible #7480

Open
thelovekesh opened this issue Mar 7, 2023 · 4 comments
Open
Labels
Enhancement New feature or improvement of an existing one P2 Low priority

Comments

@thelovekesh
Copy link
Collaborator

The existing plugin build system and toolings are made up of different bash scripts and commands (like npm and composer scripts), which never function properly on Windows. When a developer tries to work on a project on Windows with Local WP, there may be specific use situations where some procedures don't work.

Considerable tasks include the following:

  • Try to use shelljs and execute bash scripts in NodeJS.
  • Explore if we can use zx by Google to keep all our scripts platform independent using NodeJS.
@thelovekesh thelovekesh added Enhancement New feature or improvement of an existing one P2 Low priority labels Mar 7, 2023
@westonruter
Copy link
Member

I wonder how often this would be a problem on Windows now? Wouldn't most developers be using WSL and thus be able to use regular Linux utilities?

@thelovekesh
Copy link
Collaborator Author

Not sure how much the developer base faces this problem but I think less tech-savvy people can. In the current scenario, the npm run build:* command fails on Windows.

Check this job for instance: https://github.com/thelovekesh/amp-wp/actions/runs/4364834271/jobs/7632644049

@westonruter
Copy link
Member

Yeah. Well, I suggest we keep this on the backlog until we have a contributor on Windows who needs this.

@thelovekesh
Copy link
Collaborator Author

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one P2 Low priority
Projects
None yet
Development

No branches or pull requests

2 participants