Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop node < 10 #272

Merged
merged 2 commits into from Jan 17, 2020
Merged

Drop node < 10 #272

merged 2 commits into from Jan 17, 2020

Conversation

vweevers
Copy link
Member

We have a bunch of outdated dependencies (among them electron) that are blocked by this.

@vweevers vweevers added the semver-major Changes that break backward compatibility label Jan 11, 2020
@vweevers vweevers added this to Review in Airtap Jan 11, 2020
mcollina
mcollina approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vweevers
Copy link
Member Author

Build failure is nothing to worry about, small difference in sort order on newer node, will fix.

goto-bus-stop
goto-bus-stop approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vweevers vweevers merged commit 3ffdf5c into master Jan 17, 2020
Airtap automation moved this from Review to Done Jan 17, 2020
@vweevers vweevers deleted the drop-eol-node branch January 17, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ralphtheninja ralphtheninja ralphtheninja approved these changes

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

@feross feross Awaiting requested review from feross

@jhiesey jhiesey Awaiting requested review from jhiesey

Assignees
No one assigned
Labels
semver-major Changes that break backward compatibility
Projects
Airtap
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vweevers @mcollina @ralphtheninja @goto-bus-stop