From 3ffdf5c0333a98f8da58ce2fc60c1905ac03c629 Mon Sep 17 00:00:00 2001 From: Vincent Weevers Date: Fri, 17 Jan 2020 09:42:35 +0200 Subject: [PATCH] Drop node < 10 (#272) --- .travis.yml | 5 ++--- lib/aggregate-browsers.js | 2 +- package.json | 2 +- test/fixtures/aggregated-browsers.json | 4 ++-- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index ff4e7765..33467fbd 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,10 +9,9 @@ addons: language: node_js node_js: + - 13 + - 12 - 10 - - 9 - - 8 - - 6 services: - xvfb diff --git a/lib/aggregate-browsers.js b/lib/aggregate-browsers.js index bf455cd6..7b6eff3c 100644 --- a/lib/aggregate-browsers.js +++ b/lib/aggregate-browsers.js @@ -17,7 +17,7 @@ function aggregate (arr) { const versions = browsers[name].map(function (browser) { return browser.version }).sort(function (a, b) { - if (isNaN(a)) return 1 + if (isNaN(a)) return isNaN(b) ? a.localeCompare(b) : 1 if (isNaN(b)) return -1 return Number(a) - Number(b) }) diff --git a/package.json b/package.json index 15a1e749..681ce3c2 100644 --- a/package.json +++ b/package.json @@ -72,7 +72,7 @@ "hallmark": "hallmark --fix" }, "engines": { - "node": ">=6" + "node": ">=10" }, "greenkeeper": { "ignore": [ diff --git a/test/fixtures/aggregated-browsers.json b/test/fixtures/aggregated-browsers.json index a95e44c7..439a6430 100644 --- a/test/fixtures/aggregated-browsers.json +++ b/test/fixtures/aggregated-browsers.json @@ -132,8 +132,8 @@ "62", "63", "64", - "dev", - "beta" + "beta", + "dev" ], "platforms": [ "Linux",