Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clash between max-len and prefer-template #814

Closed
callumlocke opened this issue Apr 7, 2016 · 3 comments
Closed

Clash between max-len and prefer-template #814

callumlocke opened this issue Apr 7, 2016 · 3 comments

Comments

@callumlocke
Copy link

This errors because of max-len:

    let report = `<span style="color:red;font-weight:bold;font:bold 20px sans-serif">${headline}</span>`

...but if I try to break it up over multiple lines by separating it into strings and concatenating with +, it errors because of prefer-template.

What am I supposed to do in this situation?

@ljharb
Copy link
Collaborator

ljharb commented Apr 7, 2016

Temporarily disable max-len. I've filed eslint/eslint#5805 to add an ignoreStrings option to the rule which would make this example pass.

@ljharb
Copy link
Collaborator

ljharb commented Sep 7, 2016

This is pending eslint/eslint#7049 to be merged and deployed.

@ljharb
Copy link
Collaborator

ljharb commented Sep 25, 2016

This is now resolved in v8.0.0 of eslint-config-airbnb-base.

@ljharb ljharb closed this as completed Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants