Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unsupported JSCS rules in new ESLint config #5317

Closed
atimmer opened this issue Aug 5, 2016 · 2 comments
Closed

Implement unsupported JSCS rules in new ESLint config #5317

atimmer opened this issue Aug 5, 2016 · 2 comments
Labels
build tooling component: javascript

Comments

@atimmer
Copy link
Contributor

atimmer commented Aug 5, 2016 •
edited

When converting the JSCS configuration to the combined ESLint configuration the following rules were not supported:

requireSpacesInConditionalExpression
requireSpacesInFunctionExpression
requireBlocksOnNewline

We should find a way to support them. Relevant ESLint issue: eslint/eslint#5856

I've used polyjuice to convert the rules.
@afercia afercia mentioned this issue Sep 26, 2018
Closed
@afercia
Copy link
Contributor

afercia commented Sep 26, 2018

@atimmer is this still relevant?

@afercia afercia mentioned this issue Sep 26, 2018
Merged
@atimmer
Copy link
Contributor Author

atimmer commented Sep 26, 2018

I don't think so.

@atimmer atimmer closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build tooling component: javascript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atimmer @afercia @CarolineGeven