Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeDoc incorrectly marks properties with more than one source as overridden #1112

Closed
1 task done
Gerrit0 opened this issue Oct 13, 2019 · 2 comments
Closed
1 task done
Labels
bug Functionality does not match expectation

Comments

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Oct 13, 2019

Surely there's a better title... I ran into this while investigating #642, where the stack property on a custom Error type will show up as overridden since it is defined both in lib.es5.d.ts and globals.d.ts (from @types/node)

Expected Behavior

Given the following code, the stack property should show up under B as inherited from A, but not as overridden from A.

interface A {
    stack?: string
}
class A {
    stack?: string
}
class B extends A {}

Actual Behavior

image

Environment

  • Typedoc version: master
  • Node.js version: 12.x
  • OS: Windows
@Gerrit0 Gerrit0 added the bug Functionality does not match expectation label Oct 13, 2019
@Gerrit0
Copy link
Collaborator Author

Gerrit0 commented Jan 25, 2020

This should probably be addressed when fixing #1191

@Gerrit0
Copy link
Collaborator Author

Gerrit0 commented Dec 30, 2020

image
This works in 0.20.4

@Gerrit0 Gerrit0 closed this as completed Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

1 participant