ts-loader should not log compilerDetailsLogMessage when profiling

[klavs]

The following line fails to create a valid JSON because compilerDetailsLogMessage gets logged before the json.

webpack --profile --json > stats.json

compilerDetailsLogMessage should not be logged when printing webpack stats.

[johnnyreilly]

PRs welcome!

[klavs]

@sokra, @TheLarkInn, @jhnns
It makes sense to me that ts-loader outputs the tsc version and tsconfig location. Is there a way to print this info the same way as webpack does with Hash, Version and Time?

It does not seem reasonable to create a white list of cases when a loader can print something out as webpack can add new features at any time.

[jhnns]

Is there a way to print this info the same way as webpack does with Hash, Version and Time

No, I don't think so. We would need to expose a logger on the loader context. That would be a reasonable change.

Personally, I think the loader should only output something to the console if a debug flag is set.

[klavs]

Thanks @jhnns for your input.
@johnnyreilly, what do you think about logging only if debug flag is set?

[cletusw]

Is there a way to print this info the same way as webpack does with Hash, Version and Time

I know that the webpack progress indicator logs to stderr and it correctly doesn't get included in the redirected output.

[cletusw]

Interesting, looks like this should be logging to stderr as well. https://github.com/TypeStrong/ts-loader#loginfotostdout-boolean-defaultfalse

[simon04]

Having a 68 line logging module plus external colouring library seems to be an overkill for a total 5 logging invocations. Any reason not to simply use console.warn, console.error?

[johnnyreilly]

For version 3 of ts-loader we'll be changing the default log level to warn. Once that lands users will no longer be affected by this. #631 (my own "aha" moment came when I realised I was using ts-loader in silent mode by choice)

[johnnyreilly]

Closed with 3.0

[jhnns]

That's a good idea 👍. stderr was invented exactly for this purpose 😁