Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async/await support? #2

Closed
jcurtis opened this issue Dec 1, 2018 · 5 comments
Closed

async/await support? #2

jcurtis opened this issue Dec 1, 2018 · 5 comments

Comments

@jcurtis
Copy link

jcurtis commented Dec 1, 2018

I love the idea behind this config, but it's complaining about async / await in my Node 8 code.
@RyanZim
Copy link
Owner

RyanZim commented Dec 1, 2018

Do you have ecmaVersion: 8 or higher set under your parserOptions in your eslint config?

@jcurtis
Copy link
Author

jcurtis commented Dec 2, 2018

Ah, I did not. That fixes the issue. I wonder if that should be part of the node8 config?

@jcurtis
Copy link
Author

jcurtis commented Dec 2, 2018

Maybe not since this config doesn't specify any parser options. Would it get merged with project configs or just overwritten I wonder?

@RyanZim
Copy link
Owner

RyanZim commented Dec 3, 2018

I believe project configs would merge with it, with the project config having priority where they conflict.

Adding ecmaVersion to the presets would make sense if the Node version supports all new syntax in that ecmaVersion.

@RyanZim RyanZim closed this as completed in 8f2b866 Dec 5, 2018
@RyanZim
Copy link
Owner

RyanZim commented Dec 5, 2018

Done in v2.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcurtis @RyanZim