Allow disabling spread properties transpiling

bublejs · Oct 12, 2018 · 24b1fab · 24b1fab
1 parent 9a79122
commit 24b1fab
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 4 deletions.
diff --git a/src/program/types/AssignmentExpression.js b/src/program/types/AssignmentExpression.js
@@ -30,7 +30,7 @@ export default class AssignmentExpression extends Node {
 		if (this.operator === '**=' && transforms.exponentiation) {
 			this.transpileExponentiation(code, transforms);
 		} else if (/Pattern/.test(this.left.type) && transforms.destructuring) {
-			this.transpileDestructuring(code, transforms);
+			this.transpileDestructuring(code);
 		}
 
 		super.transpile(code, transforms);

diff --git a/src/program/types/ObjectExpression.js b/src/program/types/ObjectExpression.js
@@ -25,7 +25,7 @@ export default class ObjectExpression extends Node {
 			}
 		}
 
-		if (spreadPropertyCount) {
+		if (spreadPropertyCount && transforms.objectRestSpread) {
 			if (!this.program.options.objectAssign) {
 				throw new CompileError(
 					"Object spread operator requires specified objectAssign option with 'Object.assign' or polyfill helper.",

diff --git a/src/program/types/SpreadElement.js b/src/program/types/SpreadElement.js
@@ -2,7 +2,7 @@ import Node from '../Node.js';
 
 export default class SpreadElement extends Node {
 	transpile(code, transforms) {
-		if (this.parent.type == 'ObjectExpression') {
+		if (transforms.objectRestSpread && this.parent.type == 'ObjectExpression') {
 			code.remove(this.start, this.argument.start);
 			code.remove(this.argument.end, this.end);
 		}

diff --git a/test/samples/object-rest-spread.js b/test/samples/object-rest-spread.js
@@ -89,7 +89,43 @@ module.exports = [
 			var a12 = Object.assign({}, b, ( obj$8 = {}, obj$8[c] = 3, obj$8 ), {d:4});
 		`
 	},
-
+	{
+		description: 'doesn\'t transpile objects with spread with computed property if disabled',
+		options: {
+			objectAssign: 'Object.assign',
+			transforms: { objectRestSpread: false, computedProperty: false, conciseMethodProperty: false }
+		},
+		input: `
+			var a0 = { [ x ] : true , ... y };
+			var a1 = { [ w ] : 0 , [ x ] : true , ... y };
+			var a2 = { v, [ w ] : 0, [ x ] : true, ... y };
+			var a3 = { [ w ] : 0, [ x ] : true };
+			var a4 = { [ w ] : 0 , [ x ] : true , y };
+			var a5 = { k : 9 , [ x ] : true, ... y };
+			var a6 = { ... y, [ x ] : true };
+			var a7 = { ... y, [ w ] : 0, [ x ] : true };
+			var a8 = { k : 9, ... y, [ x ] : true };
+			var a9 = { [ x ] : true , [ y ] : false , [ z ] : 9 };
+			var a10 = { [ x ] : true, ...y, p, ...q };
+			var a11 = { x, [c] : 9 , y };
+			var a12 = { ...b, [c]:3, d:4 };
+		`,
+		output: `
+			var a0 = { [ x ] : true , ... y };
+			var a1 = { [ w ] : 0 , [ x ] : true , ... y };
+			var a2 = { v, [ w ] : 0, [ x ] : true, ... y };
+			var a3 = { [ w ] : 0, [ x ] : true };
+			var a4 = { [ w ] : 0 , [ x ] : true , y };
+			var a5 = { k : 9 , [ x ] : true, ... y };
+			var a6 = { ... y, [ x ] : true };
+			var a7 = { ... y, [ w ] : 0, [ x ] : true };
+			var a8 = { k : 9, ... y, [ x ] : true };
+			var a9 = { [ x ] : true , [ y ] : false , [ z ] : 9 };
+			var a10 = { [ x ] : true, ...y, p, ...q };
+			var a11 = { x, [c] : 9 , y };
+			var a12 = { ...b, [c]:3, d:4 };
+		`
+	},
 	{
 		description:
 			'transpiles inline objects with spread with computed property (#144)',