Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitive routes #5438

Merged

Conversation

paustria
Copy link
Contributor

For this enhancement: #5435

Copy link
Contributor

@pshrmn pshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #5435, I implied that there were five lines to change for this to work, but upon further review that number is actually eight. This has three of them, but is missing the changes to Route.js and Switch.js to support the sensitive prop. 😄

@paustria
Copy link
Contributor Author

@pshrmn Updated, sir. Thank you for giving the 8 lines hint. :)

@timdorr timdorr changed the title 5435: feat(sensitive case) : Added sensitive case routes support. Case sensitive routes Aug 18, 2017
@timdorr timdorr merged commit f24fb54 into remix-run:master Aug 18, 2017
@pshrmn
Copy link
Contributor

pshrmn commented Aug 24, 2017

@timdorr It looks like this got missed in the react-router-dom UMD build (ctrl+f "sensitive"). I just did a local build and it worked, so I'm not sure of the exact cause, but maybe the symlinked node_modules/react-router was stale?

https://unpkg.com/react-router-dom@4.2.0/umd/react-router-dom.js

@timdorr
Copy link
Member

timdorr commented Aug 24, 2017

Well, crap, everything is on my laptop at home. I'll take a look at it tonight.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants