fix emitting internal auth error on reconnect

redis · Jul 21, 2017 · 16632f4 · 16632f4
1 parent 50774ae
commit 16632f4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/changelog.md b/changelog.md
@@ -9,6 +9,7 @@ Features
 Bugfixes
 
 - Fixed not always copying subscribe unsubscribe arguments
+- Fixed emitting internal errors while reconnecting with auth
 
 ## v.2.7.1 - 14 Mar, 2017
 

diff --git a/index.js b/index.js
@@ -228,6 +228,8 @@ function create_parser (self) {
 RedisClient.prototype.create_stream = function () {
     var self = this;
 
+    var first_attempt = !this.stream;
+
     // Init parser
     this.reply_parser = create_parser(this);
 
@@ -304,7 +306,13 @@ RedisClient.prototype.create_stream = function () {
     // Fire the command before redis is connected to be sure it's the first fired command
     if (this.auth_pass !== undefined) {
         this.ready = true;
-        this.auth(this.auth_pass);
+        // Fail silently as we might not be able to connect
+        this.auth(this.auth_pass, function (err) {
+            if (err && first_attempt) {
+                self.command_queue.get(0).callback = noop;
+                self.emit('error', err);
+            }
+        });
         this.ready = false;
     }
 };

diff --git a/test/auth.spec.js b/test/auth.spec.js
@@ -260,9 +260,10 @@ describe('client authentication', function () {
                     password: 'wrong_password',
                     parser: parser
                 });
-                client.once('error', function (err) {
+                client.on('error', function (err) {
                     assert.strictEqual(err.message, 'ERR invalid password');
-                    done();
+                    // Make sure no other errors are reported
+                    setTimeout(done, 50);
                 });
             });