Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Generate routes for data coming in from outside phenomic #732

Closed
ben-eb opened this issue Sep 6, 2016 · 3 comments
Closed

Generate routes for data coming in from outside phenomic #732

ben-eb opened this issue Sep 6, 2016 · 3 comments

Comments

@ben-eb
Copy link
Contributor

ben-eb commented Sep 6, 2016

Currently, pages such as http://cssnano.co/optimisations/discardDuplicates will respond with a 404 error code on initial load, then the routing will kick in and display the page. This is because the data for this page comes from outside phenomic:

https://github.com/ben-eb/cssnano/blob/2ad9e47263efc6581dec1cd45ad1b2e20b9d49ab/docs/web_modules/app/metadata.js#L27

The page is then routed here:

https://github.com/ben-eb/cssnano/blob/2ad9e47263efc6581dec1cd45ad1b2e20b9d49ab/docs/web_modules/app/routes.js#L32-L35

And the page itself:

https://github.com/ben-eb/cssnano/blob/2ad9e47263efc6581dec1cd45ad1b2e20b9d49ab/docs/web_modules/layouts/Optimisations/show.js#L18

Ideally, we should be able to tell phenomic that this is a real page somehow, so that a 404 isn't thrown.

@MoOx
Copy link
Owner

MoOx commented Sep 6, 2016

I will implement a workaround so you can have this before we handle the big change related to #713 :)

ben-eb added a commit to cssnano/cssnano that referenced this issue Nov 2, 2016
This was referenced Nov 25, 2016
This was referenced Dec 9, 2016
@bloodyowl
Copy link
Contributor

Going to be fixed with #925

@MoOx MoOx mentioned this issue Jan 12, 2017
Merged
@MoOx
Copy link
Owner

MoOx commented Mar 15, 2018

Coming in next release of v1

@MoOx MoOx closed this as completed Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants