Fix return and throw propagation for yield* #24463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues in
__generator
:iter.return()
when in ayield*
, as per 14.4.13 step 7.c.viii.2.yield*
duringiter.throw()
when the delegated iterator does not have athrow
method, as per 14.4.13 step 7.b.iii.4This PR makes two changes to the
__generator
helper to fix these issues (respectively):iter.return()
on generators.ts:3256 by preserving the "return" opcode (2
).iter.throw()
on generators.ts:3255 wheny.throw
is not present by calling (and ignoring the result of)y.return()
if it exists.Fixes #24288