Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
JavaScript: handle lack of modifiers on extracted method
The emitter expects undefined, rather than empty. This only affects JS, because TS applies `private` to all extracted methods.
- Loading branch information
Showing
2 changed files
with
31 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/// <reference path='fourslash.ts' /> | ||
|
||
// Handle having zero modifiers on a method. | ||
|
||
// @allowNonTsExtensions: true | ||
// @Filename: file1.js | ||
//// class C { | ||
//// M() { | ||
//// const q = /*a*/1 + 2/*b*/; | ||
//// q.toString(); | ||
//// } | ||
//// } | ||
|
||
goTo.select('a', 'b') | ||
edit.applyRefactor({ | ||
refactorName: "Extract Method", | ||
actionName: "scope_0", | ||
actionDescription: "Extract function into class 'C'", | ||
newContent: | ||
`class C { | ||
M() { | ||
const q = this./*RENAME*/newFunction(); | ||
q.toString(); | ||
} | ||
newFunction() { | ||
return 1 + 2; | ||
} | ||
}` | ||
}); |