Stop requiring that the full range of a declaration fall within the

selection Fixes #18546 (cherry picked from commit af49c60)
microsoft · Sep 20, 2017 · 27bede8 · 27bede8
1 parent f0b7843
commit 27bede8
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 6 deletions.
diff --git a/src/harness/unittests/extractMethods.ts b/src/harness/unittests/extractMethods.ts
@@ -700,6 +700,11 @@ function parsePrimaryExpression(): any {
             }
         }|]
     }
+}`);
+        // Selection excludes leading trivia of declaration
+        testExtractMethod("extractMethod33",
+            `function F() {
+    [#|function G() { }|]
 }`);
     });
 

diff --git a/src/services/refactors/extractMethod.ts b/src/services/refactors/extractMethod.ts
@@ -1070,7 +1070,7 @@ namespace ts.refactor.extractMethod {
             if (!declInFile) {
                 return undefined;
             }
-            if (rangeContainsRange(enclosingTextRange, declInFile)) {
+            if (rangeContainsStartEnd(enclosingTextRange, declInFile.getStart(), declInFile.end)) {
                 // declaration is located in range to be extracted - do nothing
                 return undefined;
             }

diff --git a/tests/baselines/reference/extractMethod/extractMethod33.ts b/tests/baselines/reference/extractMethod/extractMethod33.ts
@@ -0,0 +1,19 @@
+// ==ORIGINAL==
+function F() {
+    function G() { }
+}
+// ==SCOPE::function 'F'==
+function F() {
+    /*RENAME*/newFunction();
+
+    function newFunction() {
+        function G() { }
+    }
+}
+// ==SCOPE::global scope==
+function F() {
+    /*RENAME*/newFunction();
+}
+function newFunction() {
+    function G() { }
+}
diff --git a/tests/cases/fourslash/extract-method-empty-namespace.ts b/tests/cases/fourslash/extract-method-empty-namespace.ts
@@ -1,8 +1,5 @@
 /// <reference path='fourslash.ts' />
 
-// TODO: GH#18546
-// For now this tests that at least we don't crash.
-
 ////function f() {
 ////    /*start*/namespace N {}/*end*/
 ////}
@@ -13,9 +10,9 @@ edit.applyRefactor({
     actionName: "scope_1",
     actionDescription: "Extract function into global scope",
     newContent: `function f() {
-    /*RENAME*/newFunction(N);
+    /*RENAME*/newFunction();
 }
-function newFunction(N: any) {
+function newFunction() {
     namespace N { }
 }
 `