For @types installing quickfix, only activate for implicit-any module (…

…#19394) (#19429)
microsoft · Oct 24, 2017 · 02cc07c · 02cc07c
1 parent 43fc3ce
commit 02cc07c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/src/services/codefixes/fixCannotFindModule.ts b/src/services/codefixes/fixCannotFindModule.ts
@@ -2,7 +2,6 @@
 namespace ts.codefix {
     registerCodeFix({
         errorCodes: [
-            Diagnostics.Cannot_find_module_0.code,
             Diagnostics.Could_not_find_a_declaration_file_for_module_0_1_implicitly_has_an_any_type.code,
         ],
         getCodeActions: context => {

diff --git a/tests/cases/fourslash/codeFixCannotFindModule.ts b/tests/cases/fourslash/codeFixCannotFindModule.ts
@@ -1,11 +1,20 @@
 /// <reference path='fourslash.ts' />
 
-////import * as abs from "abs";
+// @moduleResolution: node
+// @noImplicitAny: true
+
+// @Filename: /node_modules/abs/index.js
+////not read
+
+// @Filename: /a.ts
+/////**/import * as abs from "abs";
 
 test.setTypesRegistry({
     "abs": undefined,
 });
 
+goTo.marker();
+
 verify.codeFixAvailable([{
     description: "Install '@types/abs'",
     commands: [{

diff --git a/tests/cases/fourslash/codeFixCannotFindModule_notIfMissing.ts b/tests/cases/fourslash/codeFixCannotFindModule_notIfMissing.ts
@@ -0,0 +1,11 @@
+/// <reference path='fourslash.ts' />
+
+// @Filename: /a.ts
+////import * as abs from "abs";
+
+test.setTypesRegistry({
+    "abs": undefined,
+});
+
+// We only give the fix for an implicit-any module, not for a missing module.
+verify.not.codeFixAvailable();