Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floating promise in constructor #680

Merged
merged 1 commit into from Oct 3, 2019
Merged

Fix floating promise in constructor #680

merged 1 commit into from Oct 3, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Oct 1, 2019 •
edited

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Oct 1, 2019
@vweevers vweevers added this to In progress in Level (old board) via automation Oct 1, 2019
@vweevers vweevers mentioned this pull request Oct 1, 2019
Closed
@vweevers vweevers moved this from In progress to Review in Level (old board) Oct 1, 2019
vweevers added a commit to Level/subleveldown that referenced this pull request Oct 1, 2019
@vweevers
Temporarily test against Level/abstract-leveldown#352 and Level/level…
ea315dd 
…up#680
@vweevers vweevers merged commit cf08d94 into master Oct 3, 2019
Level (old board) automation moved this from Review to Done Oct 3, 2019
@vweevers vweevers deleted the fix-floating-promise branch October 3, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
semver-patch Bug fixes that are backward compatible
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

levelup constructor without callback causes unhandled rejection
2 participants
@vweevers @ralphtheninja