Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document mandatory methods #350

Merged
merged 1 commit into from Sep 15, 2019
Merged

Document mandatory methods #350

merged 1 commit into from Sep 15, 2019

Conversation

vweevers
Copy link
Member

Closes #346. Makes abstract-leveldown seem more strict, but this aligns better with the test suite.

@vweevers vweevers added the documentation Improvements or additions to documentation label Sep 14, 2019
@vweevers vweevers added this to In progress in Level (old board) via automation Sep 14, 2019
@vweevers vweevers moved this from In progress to Review in Level (old board) Sep 14, 2019
@vweevers vweevers merged commit d7ba459 into master Sep 15, 2019
Level (old board) automation moved this from Review to Done Sep 15, 2019
@vweevers vweevers deleted the document-mandatory-methods branch September 15, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document which abstract methods must/should be implemented
2 participants
@vweevers @ralphtheninja