Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium): roll Chromium to r669486 #4591

Merged
merged 1 commit into from Jun 15, 2019

Conversation

aslushnikov
Copy link
Contributor

This roll includes:

This roll includes:
- https://crrev.com/c/1589672/ - Include retired instruction delta in TraceEvents
Copy link
Collaborator

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure what that is. Are we going to turn it on?

@aslushnikov
Copy link
Contributor Author

+cc @ai @mbalabash

This rolls in a new Chromium into Puppeteer that supports retired instruction counter on Linux (other platforms are not supported yet).

More context: https://twitter.com/aslushnikov/status/1121816765518897152

Once this lands, you'll be able to record a trace with RTI like this:

const puppeteer = require('puppeteer');
(async () => {
  const browser = await puppeter.launch({
    // --no-sandbox is needed so that renderer process has access to RTI
    args: [ '--enable-thread-instruction-count', '--no-sandbox'],
  });
  const page = await browser.newPage();
  await page.tracing.start({path: './trace.json'});
  // run scenario
  await page.goto('https://example.com');
  // ...
  await page.tracing.stop();
  await browser.close();
}();

The resulting trace has a new 'tidelta' parameter that contains RTI.

@JoelEinbinder: I hope this answers your question too!

@aslushnikov
Copy link
Contributor Author

Thank you @acomminos for your hard work exposing RTI and landing patches to Chromium! 🎉

@aslushnikov aslushnikov merged commit 45873ea into puppeteer:master Jun 15, 2019
@aslushnikov aslushnikov deleted the roll-r669486 branch September 25, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants