fix(connection): bump websocket max received message size to 256Mb #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the max message size that DevTools can emit over the DevTools protocol: https://cs.chromium.org/chromium/src/content/browser/devtools/devtools_http_handler.cc?type=cs&q=kSendBufferSizeForDevTools&sq=package:chromium&g=0&l=83 Fix puppeteer#4543
| const ws = new WebSocket(url, [], { perMessageDeflate: false }); | ||
| const ws = new WebSocket(url, [], { | ||
| perMessageDeflate: false, | ||
| maxPayload: 256 * 1024 * 1024, // 256Mb |
There was a problem hiding this comment.
why is there a max payload at all? What would happen if there was no max and someone tried to send 8 gb?
There was a problem hiding this comment.
I guess to protect against process crashes.
JoelEinbinder
approved these changes
Jun 11, 2019
This was referenced Feb 3, 2020
This was referenced Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the max message size that DevTools can emit over the DevTools
protocol: https://cs.chromium.org/chromium/src/content/browser/devtools/devtools_http_handler.cc?type=cs&q=kSendBufferSizeForDevTools&sq=package:chromium&g=0&l=83
Test is failing on firefox since Firefox crashes when allocating 100Mb string.
Fix #4543