fix: try running without --disable-gpu on windows
#4523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like https://crbug.com/737678 and https://crbug.com/729961 are fixed - so we shouldn't need the `--disable-gpu` flag on windows headless. Reference puppeteer#1260
JoelEinbinder
approved these changes
Jun 6, 2019
This was referenced Feb 3, 2020
This was referenced Feb 22, 2020
hadley
added a commit
to rstudio/chromote
that referenced
this pull request
Jan 30, 2024
It is no longer needed as the underlying bugs have been fixed in chromium (for multiple years). This flag was dropped in puppeteer in puppeteer/puppeteer#2908 and puppeteer/puppeteer#4523.
wch
pushed a commit
to rstudio/chromote
that referenced
this pull request
Jan 30, 2024
It is no longer needed as the underlying bugs have been fixed in chromium (for multiple years). This flag was dropped in puppeteer in puppeteer/puppeteer#2908 and puppeteer/puppeteer#4523.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like https://crbug.com/737678 and https://crbug.com/729961
are fixed - so we shouldn't need the
--disable-gpuflag on windowsheadless.
Reference #1260