test: improve test coverage for Request.continue #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/api.md
Outdated
| @@ -3214,7 +3214,7 @@ Exception is immediately thrown if the request interception is not enabled. | |||
|
|
|||
| #### request.continue([overrides]) | |||
| - `overrides` <[Object]> Optional request overwrites, which can be one of the following: | |||
| - `url` <[string]> If set, the request url will be changed | |||
| - `url` <[string]> If set, the request url will be changed in a way that's not observable by page. | |||
There was a problem hiding this comment.
by page to the page
I'm not sure what this is saying to me. How could the url have been observable to the page? Is there some part of the fetch API that returns the final url requested?
There was a problem hiding this comment.
Maybe mention this is not a redirect.
Drive-by: add clarification to docs/api.md regarding chaning "URL". References puppeteer#4030
aslushnikov
force-pushed
the
better-test-coverage-for-request-continue
branch
from
5f24c36
to
0b54059
Compare
JoelEinbinder
approved these changes
Mar 5, 2019
kiku-jw
pushed a commit
to kiku-jw/puppeteer
that referenced
this pull request
Apr 6, 2019
Drive-by: add clarification to docs/api.md regarding chaning "URL". References puppeteer#4030
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by: add clarification to docs/api.md regarding
chaning "URL".
References #4030