feat(executioncontext): support bigints transferring #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
changed the title
vsemozhetbyt
changed the title
vsemozhetbyt
changed the title
vsemozhetbyt
force-pushed
the
feat-page-bigint
branch
3 times, most recently
from
1490b9e
to
b6f2dea
Compare
|
Looks cool! Can we add a test? |
vsemozhetbyt
force-pushed
the
feat-page-bigint
branch
3 times, most recently
from
12def76
to
2fd8c25
Compare
|
Tests hopefully added. TS checks still are to be fixed. |
vsemozhetbyt
force-pushed
the
feat-page-bigint
branch
from
2fd8c25
to
7fa7235
Compare
vsemozhetbyt
force-pushed
the
feat-page-bigint
branch
from
7fa7235
to
3b26411
Compare
|
I've ventured to up |
|
@aslushnikov @JoelEinbinder Should I improve something else? |
aslushnikov
approved these changes
Mar 15, 2019
kiku-jw
pushed a commit
to kiku-jw/puppeteer
that referenced
this pull request
Apr 6, 2019
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://chromedevtools.github.io/devtools-protocol/tot/Runtime#type-UnserializableValue