chore(juggler): Roll Firefox to 120450a2 #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - rebaselines C++ patchset atop of [Global Firefox Reformat](https://bugzilla.mozilla.org/show_bug.cgi?id=1511181) - rolls firefox to [120450a2](mozilla/gecko-dev@120450a) - splits out preference installation step from Puppeteer-Firefox's `install.js` into a separate `puppeteer-firefox/misc/install-preferences.js`. This script is re-used to install preferences when run with a custom executable path. - fixes issue with ScrollbarManager that was re-injecting the same stylesheet multiple times
|
I manually verified this on Linux and OSX. (CI bots don't yet run pptr-firefox) |
JoelEinbinder
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
install.jsinto a separatepuppeteer-firefox/misc/install-preferences.js. This script isre-used to install preferences when tests are run with a custom executable path.
stylesheet multiple times