fix(page): use secondary DOMWorld to drive page.select() #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch starts creating secondary DOMWorld for every connected page and switches `page.select()` to run inside the secondary world. Fix puppeteer#3327.
aslushnikov
force-pushed
the
helper-dom-world
branch
from
47298f2
to
00a21ab
Compare
| const {LifecycleWatcher} = require('./LifecycleWatcher'); | ||
| const {DOMWorld} = require('./DOMWorld'); | ||
|
|
||
| const UTILITY_WORLD_NAME = '__puppeteer_utility_world__'; | ||
|
|
There was a problem hiding this comment.
Let’s cover connecting two puppeteers to a browser with a test
There was a problem hiding this comment.
we have it already - https://github.com/GoogleChrome/puppeteer/blob/c09835fd70e144cb705eb5ae8b169e49725532bd/test/puppeteer.spec.js#L305-L316
It caused me troubles.
| @@ -50,7 +50,7 @@ class Page extends EventEmitter { | |||
| client.send('Target.setAutoAttach', {autoAttach: true, waitForDebuggerOnStart: false}), | |||
| client.send('Page.setLifecycleEventsEnabled', { enabled: true }), | |||
| client.send('Network.enable', {}), | |||
| client.send('Runtime.enable', {}), | |||
| client.send('Runtime.enable', {}).then(() => page._frameManager.ensureSecondaryDOMWorld()), | |||
There was a problem hiding this comment.
why does this have to happen after runtime.enable?
There was a problem hiding this comment.
All execution contexts will be reported before Runtime.enable returns. If there's the one with helper isolated world, it'll be reported.
JoelEinbinder
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch starts creating secondary DOMWorld for every connected
page and switches
page.select()to run inside the secondary world.Drive-by: move
DOMWorld.waitForinto Frame: in future, the shortcut will expand into calls in different DOMWorlds, e.g.frame.waitForFunctionshould be always run in main world, whereasframe.waitForSelectorin secondary.Fix #3327.