Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(juggler/readme.md): add possible solution ff-build #3801

Conversation

SlootSantos
Copy link
Contributor

Fix FF build on MacOS 10.14 (Mojave) by changed xcode-select
installation behavior

Fix FF build on MacOS 10.14 (Mojave) by changed xcode-select 
installation behavior
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@SlootSantos SlootSantos changed the title docs(juggler/README.md): Add possible solution FF-Build docs(juggler/readme.md): add possible solution ff-build Jan 18, 2019
@SlootSantos
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SlootSantos awesome, thanks! I'm still on High Sierra, and this makes updating less scary :-)

@aslushnikov aslushnikov merged commit a9ad1c3 into puppeteer:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants