Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api.md): mark optional arguments in signatures #3565

Merged

Conversation

vsemozhetbyt
Copy link
Contributor

Some [] marks were missing.

Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsemozhetbyt awesome, thank you! We'll probably lint this one day in future.

@aslushnikov aslushnikov merged commit 86e0959 into puppeteer:master Nov 19, 2018
@vsemozhetbyt vsemozhetbyt deleted the doc-api-mark-optional-args branch November 19, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants