fix(page): navigating 11 pages simultaneously should not throw warning #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavigatorWatcher subscribes to Connection to get a `Disconnected` event, causing us to hit the default max of 10 listeners constraint. Technically we don't leak anything here and can safely bump the maxListenersCount to Infinity. However, we conveniently have `CDPSession`, and can re-dispatch the event on it and keep the safety check in place.
| await page.goto(server.EMPTY_PAGE); | ||
| await page.close(); | ||
| })); | ||
| process.removeListener('warning', warningHandler); |
There was a problem hiding this comment.
This test looks like it might fail in parallel if some other test creates a warning.
JoelEinbinder
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigatorWatcher subscribes to Connection to get a
Disconnectedevent,causing us to hit the default max of 10 listeners constraint.
Technically we don't leak anything here and can safely bump
the maxListenersCount to Infinity.
However, we conveniently have
CDPSession, andcan re-dispatch the event on it and keep the safety check in place.
References #1995