feat(page): support wait options for page.setContent
#3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| timeout = 30000, | ||
| } = options; | ||
| // We rely upon the fact that document.open() will reset frame lifecycle with "init" | ||
| // lifecycle event. @see https://crrev.com/608658 | ||
| await this.evaluate(html => { |
There was a problem hiding this comment.
By the time this evaluate has finished, couldn't we have received all of the life cycle events? Then the lifecyclePromise will timeout?
There was a problem hiding this comment.
ah, I see what you mean. Done.
JoelEinbinder
approved these changes
Nov 20, 2018
aslushnikov
force-pushed
the
waituntil
branch
from
2d126b0
to
88ae816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches
page.setContentto await resources inthe new document.
NOTE: This patch changes behavior: currently,
page.setContentawaits the
"domcontentloaded"event; with this patch, we can now awaitother lifecycle events, and switched default to the
"load"event.The change is justified since current behavior made
page.setContentunusable for its main designated usecases, pushing our client
to use dataURL workaround.
Fixes #728