test: fix workers test #3527
Merged
test: fix workers test #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/worker.spec.js
Outdated
| @@ -15,7 +15,7 @@ module.exports.addTests = function({testRunner, expect}) { | |||
| expect(await worker.evaluate(() => self.workerFunction())).toBe('worker function result'); | |||
|
|
|||
| await page.goto(server.EMPTY_PAGE); | |||
| expect(page.workers()).toEqual([]); | |||
| expect(page.workers().length).toBe(1); | |||
There was a problem hiding this comment.
This doesn't make sense to me. Isn't it the opposite of what the test is testing for? EMPTY_PAGE shouldn't have any workers.
| @@ -15,7 +15,7 @@ module.exports.addTests = function({testRunner, expect}) { | |||
| expect(await worker.evaluate(() => self.workerFunction())).toBe('worker function result'); | |||
|
|
|||
| await page.goto(server.EMPTY_PAGE); | |||
| expect(page.workers()).toEqual([]); | |||
| expect(page.workers().length).toBe(0); | |||
There was a problem hiding this comment.
I don't get it. Whats the change?
There was a problem hiding this comment.
when this test fails, the output is cryptic since Worker object is not nicely serializable.
JoelEinbinder
approved these changes
Nov 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.