Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support configurations in package.json #3449

Merged
merged 2 commits into from Nov 14, 2018

Conversation

jxltom
Copy link
Contributor

@jxltom jxltom commented Oct 26, 2018

Fixes #2262 (comment)

This PR support set puppeteer_skip_chromium_download, puppeteer_download_host and puppeteer_chromium_revision in config of package.json

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jxltom
Copy link
Contributor Author

jxltom commented Oct 27, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jxltom jxltom changed the title Support configurations in package.json fix: Support configurations in package.json Oct 27, 2018
@jxltom jxltom changed the title fix: Support configurations in package.json fix: support configurations in package.json Oct 27, 2018
@aslushnikov
Copy link
Contributor

@jxltom so now when we have puppeteer-core - why would you want to have the config support?

@jxltom
Copy link
Contributor Author

jxltom commented Nov 2, 2018

Hi @aslushnikov It is because I'm not using puppeteer directly. I'm using storybook's addon snapshots which requires puppeteer rather than puppeteer-core. But I don't need chromium, so it would be nice to disable downnloading chromium in package.json.

@aslushnikov aslushnikov merged commit c185eee into puppeteer:master Nov 14, 2018
@jxltom jxltom deleted the support-config-in-package.json branch November 15, 2018 00:35
sirreal added a commit to Automattic/wp-calypso that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants