New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support configurations in package.json #3449
fix: support configurations in package.json #3449
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
@jxltom so now when we have puppeteer-core - why would you want to have the config support? |
Hi @aslushnikov It is because I'm not using puppeteer directly. I'm using storybook's addon snapshots which requires puppeteer rather than puppeteer-core. But I don't need chromium, so it would be nice to disable downnloading chromium in package.json. |
Fixes #2262 (comment)
This PR support set
puppeteer_skip_chromium_download
,puppeteer_download_host
andpuppeteer_chromium_revision
inconfig
ofpackage.json