docs: Added cutoff values for scale option in page.pdf function #3201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be useful to add the lowest and highest values for the scale option to the page.pdf function call in the api documentation. The library throws an error and doesn't generate a pdf if you go beyond those values. I didn't manually test it, the values are based on the warning Chrome gives you if you try to set the scale value outside of that range (divided by 100), so let me know if they're wrong.
It may be useful to change the behavior in the future so that if the value is set beyond that range puppeteer sets the value to the closest value within the range and throws a warning.
Let me know what you think!