Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added cutoff values for scale option in page.pdf function #3201

Merged

Conversation

jsfeldman
Copy link
Contributor

I thought it would be useful to add the lowest and highest values for the scale option to the page.pdf function call in the api documentation. The library throws an error and doesn't generate a pdf if you go beyond those values. I didn't manually test it, the values are based on the warning Chrome gives you if you try to set the scale value outside of that range (divided by 100), so let me know if they're wrong.

It may be useful to change the behavior in the future so that if the value is set beyond that range puppeteer sets the value to the closest value within the range and throws a warning.

Let me know what you think!

Added the cutoff values for the scale option in the page.pdf function call. Numbers based on chrome's warning message.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jsfeldman
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aslushnikov aslushnikov merged commit 3364659 into puppeteer:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants