fix(page): Page.goto should properly handle historyAPI in beforeunload #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -644,7 +649,11 @@ class Page extends EventEmitter { | |||
|
|
|||
| const responses = new Map(); | |||
| const listener = helper.addEventListener(this._networkManager, NetworkManager.Events.Response, response => responses.set(response.url(), response)); | |||
| const error = await watcher.navigationPromise(); | |||
| const error = await Promise.race([ | |||
| watcher.timeoutPromise(), | |||
There was a problem hiding this comment.
why await the timeout promise here? Won't the same and new document navigations be called with the timeout?
There was a problem hiding this comment.
no, I split them out (see NavigationWatcher)
JoelEinbinder
approved these changes
Sep 5, 2018
|
It's me again :D Will this fix #2479? |
|
@ntzm ah sorry, I still can repro this on tip-of-tree. Let me look into this; i forgot what was the root cause. |
|
No worries, sorry to keep bothering you :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol's
page.navigatedoesn't report loaderId if the command resulted in a same-documentnavigation. In this case we should anticipate same-document navigation and otherwise we should
wait for new document navigation.
Fixes #2764.