Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page): Added 'referer' as a parameter in options of Page.goto() #3128

Merged
merged 3 commits into from Sep 3, 2018

Conversation

aliahmad490
Copy link
Contributor

If referer is passed to the options object its value will be used as the referer instead of the value set by Page.setExtraHTTPHeaders().

Fixes #3090

@aliahmad490 aliahmad490 changed the title feat(Page) Added referer as parameter in options of Page.goto() feat(Page): Added referer as parameter in options of Page.goto() Aug 23, 2018
@aliahmad490 aliahmad490 changed the title feat(Page): Added referer as parameter in options of Page.goto() feat(page): Added referer as parameter in options of Page.goto() Aug 23, 2018
@aliahmad490 aliahmad490 changed the title feat(page): Added referer as parameter in options of Page.goto() feat(page): Added 'referer' as a parameter in options of Page.goto() Aug 23, 2018
@aliahmad490
Copy link
Contributor Author

Can anyone review this please?

@aslushnikov
Copy link
Contributor

@aliahmad490 thank you for the PR!

@aslushnikov aslushnikov merged commit 464f3b4 into puppeteer:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants