refactor: drop jshandle factory from ExecutionContext #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -8,7 +8,7 @@ | |||
| "node": ">=6.4.0" | |||
| }, | |||
| "puppeteer": { | |||
| "chromium_revision": "579032" | |||
| @@ -33,7 +33,7 @@ class Worker extends EventEmitter { | |||
| let jsHandleFactory; | |||
| this._client.once('Runtime.executionContextCreated', async event => { | |||
| jsHandleFactory = remoteObject => new JSHandle(executionContext, client, remoteObject); | |||
There was a problem hiding this comment.
remove jsHandleFactory
| @@ -27,6 +27,7 @@ const Tracing = require('./Tracing'); | |||
| const {helper, debugError, assert} = require('./helper'); | |||
| const {Coverage} = require('./Coverage'); | |||
| const {Worker} = require('./Worker'); | |||
| const {createJSHandle} = require('./ExecutionContext'); | |||
There was a problem hiding this comment.
JSHandleFromProtocol
| * @param {!Puppeteer.CDPSession} client | ||
| * @param {?Frame} parentFrame | ||
| * @param {string} frameId | ||
| */ | ||
| constructor(client, parentFrame, frameId) { | ||
| constructor(frameManager, client, parentFrame, frameId) { | ||
| this._frameManager = frameManager; |
There was a problem hiding this comment.
Not done; we need framemanager in element handle to resolve content frames
JoelEinbinder
approved these changes
Aug 16, 2018
aslushnikov
added a commit
that referenced
this pull request
Aug 17, 2018
This reverts commit d6eb3b4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
ElementHandleintoExecutionContext(for simplicity; there's no good reason to have them in separate files).ExecutionContextThis makes it easier to create execution contexts out of payloads.