Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(networkmanager): Remove header 'cookie' from request hash #2954

Merged
merged 1 commit into from Jul 31, 2018

Conversation

DonoA
Copy link
Contributor

@DonoA DonoA commented Jul 25, 2018

This fixes an issue in which a response may not be recorded or trigger an event because of differing cookie headers from the request.

I didn't see anywhere to add testing for this functionality, however if you would like tests added, just point me in the right direction.

This fixes an issue in which a response may not be recorded or trigger an event because of differing cookie headers from the request.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@DonoA DonoA changed the title fix(NetworkManager): Remove header 'cookie' from request hash fix(networkmanager): Remove header 'cookie' from request hash Jul 25, 2018
@DonoA
Copy link
Contributor Author

DonoA commented Jul 25, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll add a test for this in a follow-up.

@aslushnikov aslushnikov merged commit 0b12119 into puppeteer:master Jul 31, 2018
aslushnikov pushed a commit to aslushnikov/puppeteer that referenced this pull request Aug 1, 2018
…eer#2954)

This fixes an issue in which a response may not be recorded or trigger an event because of differing cookie headers from the request.

References puppeteer#2970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants