docs(readme): update FAQ #2826
Merged
docs(readme): update FAQ #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
reviewed
Jun 30, 2018
README.md
Outdated
|
|
||
| However, oftentimes it is desirable to use Puppeteer with the official Google Chrome rather than Chromium. For this to work, you should pick the version of Puppeteer that uses the Chromium version close enough to Chrome. You can check for Puppeteer's Chromium revision in Release notes or in version selector on [pptr.dev](https://pptr.dev). | ||
|
|
||
| #### Q: What’s “Navigation”? |
There was a problem hiding this comment.
What's considered a "Navigation"?
ebidel
reviewed
Jun 30, 2018
README.md
Outdated
|
|
||
| With this definition of “navigation,” **Puppeteer works seamlessly with single-page applications.** | ||
|
|
||
| #### Q: What’s a “trusted input”? |
There was a problem hiding this comment.
What’s the difference between a “trusted" and "untrusted" input event?
ebidel
reviewed
Jun 30, 2018
| @@ -236,40 +236,76 @@ Check out [contributing guide](https://github.com/GoogleChrome/puppeteer/blob/ma | |||
|
|
|||
| # FAQ | |||
|
|
|||
| #### Q: Which Chromium version does Puppeteer use? | |||
|
|
|||
| Look for `chromium_revision` in [package.json](https://github.com/GoogleChrome/puppeteer/blob/master/package.json). | |||
There was a problem hiding this comment.
Think we should keep this one. "Which Chromium version does Puppeteer use?" so people know how to lookup the version.
There was a problem hiding this comment.
Brought it back right after "Why puppeteer vXXX doesn't work with chromium vYYY"
|
@ebidel how do you feel about this? |
ebidel
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.