fix(page): teach page.click() to click partially offscreen buttons #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, we use `Element.scrollIntoViewIfNeeded` to make sure button is on screen before trying to click it. However, `Element.scrollIntoViewIfNeeded` doesn't work in certain scenarios, e.g. when element is partially visible and horizontal scrolling is required to make it fully visible. This patch polyfills `element.scrollIntoViewIfNeeded` using IntersectionObserver and `Element.scrollIntoView`. Fixes puppeteer#2804.
lib/ElementHandle.js
Outdated
| }); | ||
| observer.observe(element); | ||
| }); | ||
| if (Math.abs(visibleRatio - 1.0) > 1e-3) |
There was a problem hiding this comment.
1e-3 is scary. Lets just compare to 1
JoelEinbinder
approved these changes
Jun 27, 2018
|
Just wanted to say that it's an amazing feeling to run into an issue, track it down, and find out it's already been solved! Keep up the great work, guys!! @aslushnikov @JoelEinbinder 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, we use
Element.scrollIntoViewIfNeededto make surebutton is on screen before trying to click it.
However,
Element.scrollIntoViewIfNeededdoesn't work in certainscenarios, e.g. when element is partially visible and horizontal
scrolling is required to make it fully visible.
This patch polyfills
element.scrollIntoViewIfNeededusingIntersectionObserver and
Element.scrollIntoView.Fixes #2804.