Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(worker): implement pageerror event from a worker #2795

Merged
merged 3 commits into from
Jun 25, 2018
Merged

feat(worker): implement pageerror event from a worker #2795

merged 3 commits into from
Jun 25, 2018

Conversation

yanivefraim
Copy link
Contributor

@yanivefraim yanivefraim commented Jun 23, 2018 •
edited

This will fix #2761

@yanivefraim yanivefraim changed the title feat(worker): implement 'pageerror' event from a worker feat(worker): implement pageerror event from a worker Jun 23, 2018
@yanivefraim yanivefraim changed the title feat(worker): implement pageerror event from a worker feat(worker): implement pageerror event from a worker Jun 23, 2018
aslushnikov
aslushnikov approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aslushnikov aslushnikov merged commit aae73f5 into puppeteer:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web Worker errors are not collected by page.on('pageerror'...
2 participants
@yanivefraim @aslushnikov