fix(page): migrate exposeFunction from console.debug to Runtime.installBinding #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is demo PR, it shows how new binding API may be used instead of console.debug. It requires at least rolling Chromium with Runtime.installBinding before merging. |
|
This is awesome. @kozy: pptr's chromium version already includes your binding patches to V8; this should all work once you rebaseline this PR on tip-of-tree. |
alexkozy
force-pushed
the
migrate-to-binding
branch
from
1ba3fe5
to
fc899a1
Compare
alexkozy
force-pushed
the
migrate-to-binding
branch
from
fc899a1
to
13ddd60
Compare
|
Andrey, I believe that this PR is ready! :) |
aslushnikov
changed the title
aslushnikov
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New way is faster and cleaner.