Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A3 paper size is incorrect #4568

Closed
swordman1205 opened this issue Jun 11, 2019 · 3 comments · Fixed by #4569
Closed

A3 paper size is incorrect #4568

swordman1205 opened this issue Jun 11, 2019 · 3 comments · Fixed by #4569

Comments

@swordman1205
Copy link

I was trying to generate PDF using this library. However, I noticed the size of A3 format is incorrect. The correct size should be 297mm x 420mm, but the generated PDF size is 297mm x 419mm.

Steps to reproduce

Call pdf function with param { format: 'A3' }.

Tell us about your environment:

  • Puppeteer version: 1.17.0
  • Platform / OS version: Mac OS High Sierra / Linux
  • URLs (if applicable):
  • Node.js version: 10.x

What is the expected result?
The A3 format size should be 297mm x 420mm.
@swordman1205
Copy link
Author

Screen Shot 2019-06-11 at 4 04 41 AM

@sapics sapics mentioned this issue Jun 11, 2019
Merged
aslushnikov pushed a commit that referenced this issue Jun 11, 2019
@sapics @aslushnikov
fix(page): fix A2 and A3 format size (#4569)
7922641 
16.5 inch ~ 419.1mm
16.54 inch ~ 420.1mm

Fix #4568
@swordman1205
Copy link
Author

So @sapics @aslushnikov can you please release a new version for this update so that I can integrate this change?

@aslushnikov
Copy link
Contributor

@swordman1205 there's a puppeteer@next for the tip-of-tree version of puppeteer:

npm i puppeteer@next

Our next release is scheduled for June, 21. Will the puppeteer@next work for you in the meantime?

@snyk-bot snyk-bot mentioned this issue Dec 4, 2019
Open
This was referenced Feb 3, 2020
Open
Open
This was referenced Feb 22, 2020
Open
Open
@snyk-bot snyk-bot mentioned this issue Mar 10, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 13, 2020
Merged
@snyk-bot snyk-bot mentioned this issue May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(page): fix A2 and A3 format size
3 participants
@aslushnikov @swordman1205 and others