Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page.select throwing error when select change page #4537

Closed
gilles-yvetot opened this issue Jun 6, 2019 · 0 comments · Fixed by #4539
Closed

Page.select throwing error when select change page #4537

gilles-yvetot opened this issue Jun 6, 2019 · 0 comments · Fixed by #4539

Comments

@gilles-yvetot
Copy link

Steps to reproduce

What steps will reproduce the problem?

page.select('#language','fr')

What is the expected result?

  1. Go to the MDN url indicated
  2. scroll to the bottom of the page
  3. change the language in the dropdown
  4. it will redirect you to the MDN homepage of the chosen language

What happens instead?

It does this but throw an error at the same time. The issue seems to be that the select is triggering a page load and we are loosing the reference to the specified DOM element.
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jun 7, 2019
@aslushnikov
fix(page): do evaluations with one roundtrip
778f603 
This patch teaches page.evaluate to do 1 hop instead of 2 hops.
As a result, things such as `page.select` will not throw an
unfortunate exception when they schedule a navigation.

Fix puppeteer#4537
@aslushnikov aslushnikov mentioned this issue Jun 7, 2019
Merged
aslushnikov added a commit that referenced this issue Jun 7, 2019
@aslushnikov
fix(page): do evaluations with one roundtrip (#4539)
90df69c 
This patch teaches page.evaluate to do 1 hop instead of 2 hops.
As a result, things such as `page.select` will not throw an
unfortunate exception when they schedule a navigation.

Fix #4537
@aslushnikov aslushnikov mentioned this issue Jun 21, 2019
Closed
@aslushnikov aslushnikov mentioned this issue Jul 15, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Dec 4, 2019
Open
This was referenced Feb 3, 2020
Open
Open
This was referenced Feb 22, 2020
Open
Open
@snyk-bot snyk-bot mentioned this issue Mar 10, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 13, 2020
Merged
@snyk-bot snyk-bot mentioned this issue May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(page): do evaluations with one roundtrip aslushnikov/puppeteer
1 participant
@gilles-yvetot