browser.close hangs with beforeunload dialog

[aslushnikov]

Puppeteer: v1.11.0

In headful mode, browser.close doesn't force-close browser, stalling the process in case of beforeunload dialogs. This is a little surprising to me - I'd expect beforeunloads to be ignored by default.

const puppeteer = require('puppeteer');

(async() => {
  const browser = await puppeteer.launch({
    headless: false,
    userDataDir: 'ppp',
  });
  const page = await browser.newPage();
  await page.goto('https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_onbeforeunload');
  const frame = page.frames().find(frame => frame.name() === 'iframeResult');
  await Promise.all([
    // make sure beforeunload triggers once
    new Promise(resolve => page.once('dialog', resolve)).then(dialog => dialog.dismiss()),
    frame.click('a'),
  ]);
  // This will hang forever
  console.log('Exiting...');
  await browser.close();
  console.log('Done.');
})();

[gidztech]

I made a PR to fix this.

[aslushnikov]

This was fixed upstream at https://crrev.com/618425