Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppeteer@next is not autoupdated #2925

Closed
aslushnikov opened this issue Jul 20, 2018 · 5 comments
Closed

puppeteer@next is not autoupdated #2925

aslushnikov opened this issue Jul 20, 2018 · 5 comments
Assignees
@aslushnikov
Labels
health

Comments

@aslushnikov
Copy link
Contributor

Recent eslint hack caused all NPM keys to be invalidated. This broke our puppeteer@next self-deployment through travis-ci.
@aslushnikov aslushnikov self-assigned this Jul 20, 2018
@aslushnikov aslushnikov mentioned this issue Jul 20, 2018
Closed
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jul 20, 2018
@aslushnikov
chore(ci): fix auto-publish to travis
20432f2 
Fixes puppeteer#2925.
@aslushnikov aslushnikov mentioned this issue Jul 20, 2018
Merged
aslushnikov added a commit that referenced this issue Jul 21, 2018
@aslushnikov
chore(ci): fix auto-publish to travis (#2930)
8f5ecf5 
Fixes #2925.
@aslushnikov
Copy link
Contributor Author

Ok, this didn't work.

@aslushnikov aslushnikov reopened this Jul 21, 2018
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jul 21, 2018
@aslushnikov
chore(ci): fix auto-publish to travis
c8458a5 
Fixes puppeteer#2925.
@aslushnikov aslushnikov mentioned this issue Jul 21, 2018
Merged
aslushnikov added a commit that referenced this issue Jul 21, 2018
@aslushnikov
chore(ci): fix auto-publish to travis (#2931)
1d5f52e 
Fixes #2925.
@aslushnikov
Copy link
Contributor Author

no luck!

@aslushnikov aslushnikov reopened this Jul 21, 2018
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jul 23, 2018
@aslushnikov
chore(ci): use specific npm version
9e29827 
References puppeteer#2925.
@aslushnikov aslushnikov mentioned this issue Jul 23, 2018
Closed
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jul 23, 2018
@aslushnikov
chore(ci): yet another attempt to fix pptr@next
aa57a87 
References puppeteer#2925.
@aslushnikov aslushnikov mentioned this issue Jul 23, 2018
Closed
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jul 23, 2018
@aslushnikov
chore(ci): yet another attempt to fix pptr@next
6dc4c9d 
References puppeteer#2925.
@aslushnikov aslushnikov mentioned this issue Jul 23, 2018
Merged
aslushnikov added a commit that referenced this issue Jul 24, 2018
@aslushnikov
chore(ci): yet another attempt to fix pptr@next (#2940)
5b18987 
References #2925.
@aslushnikov
Copy link
Contributor Author

It works!

@ntzm
Copy link
Contributor

ntzm commented Sep 6, 2018

I think this is still a little broken, the latest commit d54c7ed isn't on next

@aslushnikov
Copy link
Contributor Author

@ntzm crazy. Indeed.

@aslushnikov aslushnikov reopened this Sep 6, 2018
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Sep 6, 2018
@aslushnikov
chore: fix puppeteer@next race condition.
7d56997 
When we merge commits to master, Travis kicks job to build a new commit
and to publish new version of puppeteer@next.

If two commits are landed in almost the same time, then travis starts
two parallel jobs to build each commit. This race condition results
in the incorrect puppeteer@next revision.

This patch teaches apply_next_version.js to verify if current HEAD
is matching upstream HEAD. If it doesn't, the predeploy hook fails
which (hopefully) aborts deployment.

Fixes puppeteer#2925.
@aslushnikov aslushnikov mentioned this issue Sep 6, 2018
Merged
aslushnikov added a commit that referenced this issue Sep 6, 2018
@aslushnikov
chore: fix puppeteer@next race condition (#3209)
b7e922b 
When we merge commits to master, Travis kicks job to build a new commit
and to publish new version of puppeteer@next.

If two commits are landed in almost the same time, then travis starts
two parallel jobs to build each commit. This race condition results
in the incorrect puppeteer@next revision.

This patch teaches apply_next_version.js to verify if current HEAD
is matching upstream HEAD. If it doesn't, the predeploy hook fails
which (hopefully) aborts deployment.

Fixes #2925.
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Sep 6, 2018
@aslushnikov
chore: another attempt to fix pptr@next
330e3c8 
It turns out that travis runs commands in sh rather then in bash.

Fixes puppeteer#2925.
@aslushnikov aslushnikov mentioned this issue Sep 6, 2018
Merged
aslushnikov added a commit that referenced this issue Sep 6, 2018
@aslushnikov
chore: another attempt to fix pptr@next (#3210)
42fde9b 
It turns out that travis runs commands in sh rather then in bash.

Fixes #2925.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslushnikov @ntzm