Skip to content

Commit

Permalink
feat(firefox): roll Firefox to 765beffc (#4156)
Browse files Browse the repository at this point in the history
This roll fixes flaky request interception in Firefox and moves
`Page.console` event to the Runtime domain.
  • Loading branch information
aslushnikov committed Mar 12, 2019
1 parent 42351c7 commit e3a4f34
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion experimental/puppeteer-firefox/lib/Page.js
Expand Up @@ -58,7 +58,7 @@ class Page extends EventEmitter {
this._networkManager.setFrameManager(this._frameManager);
this._eventListeners = [
helper.addEventListener(this._session, 'Page.uncaughtError', this._onUncaughtError.bind(this)),
helper.addEventListener(this._session, 'Page.console', this._onConsole.bind(this)),
helper.addEventListener(this._session, 'Runtime.console', this._onConsole.bind(this)),
helper.addEventListener(this._session, 'Page.dialogOpened', this._onDialogOpened.bind(this)),
helper.addEventListener(this._session, 'Page.bindingCalled', this._onBindingCalled.bind(this)),
helper.addEventListener(this._frameManager, Events.FrameManager.Load, () => this.emit(Events.Page.Load)),
Expand Down
2 changes: 1 addition & 1 deletion experimental/puppeteer-firefox/package.json
Expand Up @@ -9,7 +9,7 @@
"node": ">=8.9.4"
},
"puppeteer": {
"firefox_revision": "d152aecb47c733342b7a8691e899f7b2981ef797"
"firefox_revision": "765beffcf39dc68cb2005b2b5343e283e26df7a3"
},
"scripts": {
"install": "node install.js",
Expand Down

0 comments on commit e3a4f34

Please sign in to comment.