Skip to content

Commit

Permalink
feat(chromium): roll Chromium to r587164 (#3153)
Browse files Browse the repository at this point in the history
This roll includes:
- https://crrev.com/584293 - DevTools: execute scripts in addScriptToEvaluateOnLoad in order
- https://crrev.com/585630 - DevTools: introduce Browser.grantPermissions
- https://crrev.com/587156 - Revert "[Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland)."

The "revert" patch fixes headless functionality on windows.

References #846.
Fixes #3106.
  • Loading branch information
aslushnikov committed Aug 30, 2018
1 parent bfed64f commit df459ba
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -8,7 +8,7 @@
"node": ">=6.4.0"
},
"puppeteer": {
"chromium_revision": "583214"
"chromium_revision": "587164"
},
"scripts": {
"unit": "node test/test.js",
Expand Down
9 changes: 9 additions & 0 deletions test/page.spec.js
Expand Up @@ -914,6 +914,15 @@ module.exports.addTests = function({testRunner, expect, headless}) {
});
expect(result).toBe(36);
});
it('should be callable from-inside evaluateOnNewDocument', async({page, server}) => {
let called = false;
await page.exposeFunction('woof', function() {
called = true;
});
await page.evaluateOnNewDocument(() => woof());
await page.reload();
expect(called).toBe(true);
});
it('should survive navigation', async({page, server}) => {
await page.exposeFunction('compute', function(a, b) {
return a * b;
Expand Down

0 comments on commit df459ba

Please sign in to comment.